Skip to content

Conversation

@andrew000
Copy link
Contributor

I use this methods to serialize text into Message/Term/etc in my Fluent Extractor.

It would be great to make them public

@alerque
Copy link
Collaborator

alerque commented May 23, 2025

As the original movers and drivers of the serializer feature getting merged at all @Michael-F-Bryan and @RumovZ, do you have any input relevant to making these bits public?

@alerque
Copy link
Collaborator

alerque commented May 23, 2025

Tangentially related, #374.

@RumovZ
Copy link
Contributor

RumovZ commented May 24, 2025

Nope, wouldn't mind.

@andrew000
Copy link
Contributor Author

Any news?

Copy link
Collaborator

@zbraniecki zbraniecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@andrew000
Copy link
Contributor Author

Are we ready to merge? @alerque

@andrew000
Copy link
Contributor Author

Any news?

1 similar comment
@andrew000
Copy link
Contributor Author

Any news?

@danielrainer
Copy link

danielrainer commented Nov 8, 2025

We're currently looking into building tooling around converting gettext PO files to FTL files and adding some utilities for renaming identifiers and keeping FTL files tidy for fish1. For this, we would need to be able to parse FTL files, modify the parsed data, and serialize it back so that we can update the FTL files. I just started looking into the available APIs from fluent-rs, but having a serializer available is almost certainly something we would need.

This PR is very small (it only adds a few pub modifiers) and has already been approved. Is there anything preventing it from being merged?

Footnotes

  1. https://github.com/fish-shell/fish-shell/pull/11928

@waywardmonkeys
Copy link
Collaborator

Since this was approved, I'm going to go ahead and land this.

@waywardmonkeys waywardmonkeys merged commit 55c21ab into projectfluent:main Nov 9, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants